Rename fixture classes that were causing warnings #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1822 +/- ##
==========================================
- Coverage 90.10% 90.10% -0.01%
==========================================
Files 299 299
Lines 39521 39521
Branches 8582 8582
==========================================
- Hits 35611 35609 -2
- Misses 2589 2590 +1
- Partials 1321 1322 +1 ☔ View full report in Codecov by Sentry. |
jonathangreen
force-pushed
the
chore/rename-fixture-class
branch
from
113645f to
98840af
Compare
jonathangreen
force-pushed
the
chore/rename-fixture-class
branch
from
98840af to
4bf0dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename two fixture classes to avoid warnings. And make pytest treat
PytestWarningas an error, so that we notice these sooner in the future. Since its easy to name fixture classes incorrectly by accident.Motivation and Context
Two fixture classes
TestHttpFixtureandTestLicenseFixturewere causing Pytest warnings because they were being loaded as tests because the class name started withTest.How Has This Been Tested?
Running tests in CI
Checklist