PP-1219: Fixes overdrive monitor failures. #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdilauro
approved these changes
May 2, 2024
tests/api/test_overdrive.py
Outdated
| @@ -2233,6 +2233,15 @@ def test_no_drm_fulfillment(self, overdrive_api_fixture: OverdriveAPIFixture): | |||
| assert fulfill.content_link_redirect is True | |||
| assert fulfill.content_link == "https://example.org/epub-redirect" | |||
|
|
|||
| def test_bug_fix_pp_1219(self, overdrive_api_fixture: OverdriveAPIFixture): | |||
There was a problem hiding this comment.
Could we give this test method a more descriptive name? I'm guessing something like test_no_recently_changed_books.
tests/api/test_overdrive.py
Outdated
| ) as get_book_list: | ||
| get_book_list.return_value = ([], None) | ||
| result = overdrive_api_fixture.api.recently_changed_ids(utc_now(), None) | ||
| # this should no longer fail. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/19.0.1 #1819 +/- ##
=================================================
- Coverage 90.32% 90.32% -0.01%
=================================================
Files 260 260
Lines 28733 28733
Branches 6525 6525
=================================================
- Hits 25954 25953 -1
Misses 1840 1840
- Partials 939 940 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dbernstein
added a commit
that referenced
this pull request
May 2, 2024
2 tasks
dbernstein
added a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update fixes a bug introduced in #1783. It appears that the way I have overridden the NewTitlesOverdriveMonitor construct is resulting in a failure in the dependency injection code when running in production. Additionally there was a string interpolation bug in an area of the code that was not previously covered.
When this PR has been approved I'll deploy a hotfix as well as create a PR against main with these changes and I'll create a 20.0.1 release before deploying out to staging.
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1219
How Has This Been Tested?
Checklist