Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Celery automatic task naming #1809

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

jonathangreen
Copy link
Member

Description

Override Celery automatic task naming, so that all of our tasks are not prefixed with: palace.manager.celery.tasks.

See Celery docs: https://docs.celeryq.dev/en/stable/userguide/tasks.html#changing-the-automatic-naming-behavior

I'd like to make sure this one gets merged before we cut a release containing: #1802.

Motivation and Context

Make it easier to reference our tasks on the command line, in config and move them around in the package in the future if we want to.

How Has This Been Tested?

  • Tested locally
  • Tested in CI

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team April 29, 2024 13:38
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (74c483f) to head (c07deb7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1809   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files         298      299    +1     
  Lines       39638    39643    +5     
  Branches     8596     8596           
=======================================
+ Hits        35683    35688    +5     
  Misses       2625     2625           
  Partials     1330     1330           
Flag Coverage Δ
manager 89.82% <100.00%> (+<0.01%) ⬆️
migration 24.60% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎸

@jonathangreen jonathangreen merged commit 6b4a738 into main Apr 29, 2024
21 checks passed
@jonathangreen jonathangreen deleted the feature/update-celery-task-names branch April 29, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants