Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP-1158] Remove deferredtasks. #1795

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

dbernstein
Copy link
Contributor

@dbernstein dbernstein commented Apr 17, 2024

Description

The deferredtasks table is no longer being used: therefore, let it be removed.

DO NOT MERGE UNTIL #1794 has been added to a release.

The tests won't pass on this PR until the above PR is merged and this PR is rebased on it.

Motivation and Context

https://ebce-lyrasis.atlassian.net/browse/PP-1158

How Has This Been Tested?

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@dbernstein dbernstein force-pushed the PP-1158-remove-deferred-tasks-table branch from 31affaf to 5cc028c Compare April 17, 2024 22:29
@dbernstein dbernstein requested a review from a team April 17, 2024 22:30
@dbernstein dbernstein force-pushed the PP-1158-remove-deferred-tasks-table branch from 5cc028c to 7840c0b Compare April 17, 2024 22:33
@dbernstein dbernstein changed the title [PP-1158] Remove deferredtasks table. [PP-1158] Remove deferredtasks. Apr 17, 2024
@jonathangreen jonathangreen marked this pull request as draft April 18, 2024 16:00
@jonathangreen
Copy link
Member

@dbernstein I marked this one as a draft until its ready to go in

@jonathangreen jonathangreen added the DB migration This PR contains a DB migration label Apr 18, 2024
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming CI is all good once other PR goes in.

@dbernstein dbernstein force-pushed the PP-1158-remove-deferred-tasks-table branch from 7840c0b to 311b2d9 Compare April 19, 2024 18:39
Remove deferredtask  module and related tests.
Add migration to remove the table in the database.
@dbernstein dbernstein force-pushed the PP-1158-remove-deferred-tasks-table branch from 311b2d9 to 86b0722 Compare April 22, 2024 17:28
@dbernstein dbernstein marked this pull request as ready for review April 22, 2024 17:28
@dbernstein dbernstein merged commit 4376882 into main Apr 22, 2024
24 checks passed
@dbernstein dbernstein deleted the PP-1158-remove-deferred-tasks-table branch April 22, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB migration This PR contains a DB migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants