Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __init__.py files #1762

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Add __init__.py files #1762

merged 2 commits into from
Apr 5, 2024

Conversation

jonathangreen
Copy link
Member

Description

Some of our modules were missing __init__.py files to mark the directory as a module. I think this is causing some subtle problems with imports, since that makes these folder namespace packages instead of modules.

Motivation and Context

Make sure we are consistently using __init__.py to mark modules in the package.

How Has This Been Tested?

  • Running tests in CI.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team April 4, 2024 22:11
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (23b26e3) to head (c644c82).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1762   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files         247      247           
  Lines       28305    28305           
  Branches     6447     6454    +7     
=======================================
+ Hits        25538    25539    +1     
+ Misses       1830     1829    -1     
  Partials      937      937           
Flag Coverage Δ
Api 75.81% <ø> (-0.17%) ⬇️
Core 59.42% <ø> (-0.42%) ⬇️
migration 24.09% <ø> (-2.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Funny. I don't ever recall running into a problem because of this.

@jonathangreen jonathangreen merged commit 22e9719 into main Apr 5, 2024
24 checks passed
@jonathangreen jonathangreen deleted the feature/add_init_files branch April 5, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants