Add library name to loan notifications (PP-1011) #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1721 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 245 245
Lines 28201 28202 +1
Branches 6447 6447
=======================================
+ Hits 25443 25444 +1
Misses 1822 1822
Partials 936 936
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, holds and loan expiry notifications from the Palace app do not contain the library name. While many users likely have only one library added in the Palace app, for any user having more than 1 library added to the app, the library name not included in the Hold Ready notification can be confusing when trying to borrow a book that has become available.
Motivation and Context
See: PP-1011. Related to the changes in #1714.
How Has This Been Tested?
Running unit tests.
Checklist