Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize CachedData cache for distributor customlist searches. (PP-1045) #1715

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Initialize CachedData cache for distributor customlist searches. (PP-1045) #1715

merged 1 commit into from
Mar 8, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Mar 8, 2024 •
edited by jira bot
Loading

Description

Initializes CacheData in the bin/custom_list_update_new_entries CLI script, so that custom list searches that include distributor work properly.

Motivation and Context

Some custom lists were not properly updating or repopulating.

[Jira PP-1045]

How Has This Been Tested?

  • Tested locally in a local development environment.
  • Ran a version of the script on two production servers that were impacted by the problem.
  • CI tests pass for associated branch.

Checklist

  • N/A I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro marked this pull request as ready for review March 8, 2024 21:31
@tdilauro tdilauro requested a review from a team March 8, 2024 21:32
jonathangreen
jonathangreen approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘🏻

@jonathangreen jonathangreen added the bug Something isn't working label Mar 8, 2024
@tdilauro tdilauro merged commit 582b3b3 into main Mar 8, 2024
28 checks passed
@tdilauro tdilauro deleted the bugfix/customlist-not-refreshing branch March 8, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathangreen jonathangreen jonathangreen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdilauro @jonathangreen