Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular import issue. (PP-1016) #1699

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Feb 27, 2024

Description

Fixes a circular imports in

  • one of the SAML scripts and
  • a couple of SAML modules.

Motivation and Context

SAML federation configuration and monitor scripts weren't completing successfully due to circular references.

[Jira PP-1016]

How Has This Been Tested?

Checklist

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro added the bug Something isn't working label Feb 27, 2024
@tdilauro tdilauro requested a review from a team February 27, 2024 17:38
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tdilauro tdilauro merged commit 55801b5 into main Feb 27, 2024
28 checks passed
@tdilauro tdilauro deleted the bugfix/add-saml-federation branch February 27, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants