Update email sending to be configured as a service in a container (PP-893) #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
feature/speed-up-loading
branch
from
a1852b1 to
9b3d2f1
Compare
jonathangreen
force-pushed
the
feature/mailer-service
branch
from
1863927 to
7ccb185
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
+ Coverage 89.97% 89.99% +0.01%
==========================================
Files 244 246 +2
Lines 28447 28476 +29
Branches 6493 6494 +1
==========================================
+ Hits 25595 25626 +31
+ Misses 1895 1893 -2
Partials 957 957
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonathangreen
force-pushed
the
feature/mailer-service
branch
from
7ccb185 to
550adc4
Compare
jonathangreen
added
the
incompatible changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update email sending configuration to be set in "PALACE_" env vars, instead of "SIMPLIFIED_", via a service configuration.
🚨 This one can't go in until there is a PR to update hosting-playbook. So I'm setting it in draft state until then.PR for this here: https://github.com/ThePalaceProject/hosting-playbook/pull/568
Motivation and Context
Part of the cleanup work for PP-4.
How Has This Been Tested?
Checklist