Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revoke response respects accept header (PP-886) #1645

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Revoke response respects accept header (PP-886) #1645

merged 2 commits into from
Jan 31, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Jan 30, 2024 •
edited by jira bot
Loading

Description

  • revoke response respects Accept header.
  • DRYed out some tests while adding new ones for this functionality.

Motivation and Context

[Jira PP-886]

How Has This Been Tested?

  • Manually tested functionality in local dev environment.
  • Updated tests to explicitly cover OPDS 1 and 2 serializations.
  • CI tests for associated branch passed.

Checklist

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested review from a team and removed request for a team January 30, 2024 23:18
jonathangreen
jonathangreen approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tdilauro tdilauro merged commit f883417 into main Jan 31, 2024
28 checks passed
@tdilauro tdilauro deleted the feature/revoke-response-respects-accept-header branch January 31, 2024 14:34
@jonathangreen jonathangreen added the feature New feature label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathangreen jonathangreen jonathangreen approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdilauro @jonathangreen