Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove first book auth API (PP-903) 🔥 #1642

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

jonathangreen
Copy link
Member

Description

  • Remove the unused Firstbook Auth API.
  • Update the static files route so its only added if its needed.
    • Update the static files controller, since its only used in a very simple case now.

Motivation and Context

  • I was looking into what the static files sitewide setting was used for, and it was only used here. Looking at firstbook, it doesn't seem like we are using it anywhere.

How Has This Been Tested?

  • Tested locally
  • Tested in debug config with local admin UI
  • Running tests in CI

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (178f69c) 89.61% compared to head (87f3a4f) 89.56%.

Files Patch % Lines
api/admin/routes.py 28.57% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
- Coverage   89.61%   89.56%   -0.05%     
==========================================
  Files         247      246       -1     
  Lines       28952    28875      -77     
  Branches     6608     6600       -8     
==========================================
- Hits        25944    25862      -82     
- Misses       2024     2029       +5     
  Partials      984      984              
Flag Coverage Δ
Api 75.46% <54.54%> (-0.09%) ⬇️
Core 59.07% <0.00%> (+0.13%) ⬆️
migration 26.50% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen force-pushed the feature/remove-firstbook-auth branch from 561c939 to 87f3a4f Compare January 29, 2024 20:20
@jonathangreen jonathangreen requested a review from a team January 30, 2024 15:30
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonathangreen jonathangreen merged commit cd2a250 into main Jan 30, 2024
27 of 28 checks passed
@jonathangreen jonathangreen deleted the feature/remove-firstbook-auth branch January 30, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants