Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pre-load our configuration settings table cache anymore (PP-893) #1641

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jonathangreen
Copy link
Member

Description

Now that we aren't using ConfigurationSettings anywhere. We don't need to populate the cache for them on configuration loads.

Motivation and Context

Removing the remaining Config settings pieces.

How Has This Been Tested?

Tested locally.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e5a17c) 89.61% compared to head (e0e717a) 89.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
- Coverage   89.61%   89.60%   -0.01%     
==========================================
  Files         247      247              
  Lines       28954    28954              
  Branches     6608     6608              
==========================================
- Hits        25946    25944       -2     
  Misses       2025     2025              
- Partials      983      985       +2     
Flag Coverage Δ
Api 75.54% <ø> (-0.01%) ⬇️
Core 58.92% <ø> (ø)
migration 26.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen requested a review from a team January 30, 2024 15:30
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@jonathangreen jonathangreen merged commit 409865a into main Jan 30, 2024
28 checks passed
@jonathangreen jonathangreen deleted the feature/remove-configuration-caching branch January 30, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants