Refactor controller tests to use flask_app_fixture (PP-893) #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
feature/remove-settings-controller-usages
branch
2 times, most recently
from
1a585d2 to
6bcde83
Compare
jonathangreen
force-pushed
the
feature/remove-settings-controller-usages
branch
from
6bcde83 to
975dfbe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
=======================================
Coverage 89.61% 89.61%
=======================================
Files 247 247
Lines 28954 28952 -2
Branches 6608 6608
=======================================
- Hits 25946 25945 -1
+ Misses 2025 2024 -1
Partials 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonathangreen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor tests to use the new flask_app_fixture defined in #1632. Remove a couple uses of the
SettingsControllerclass.This cleanup was done in anticipation of the removal of the ExternalIntegration, ConfigurationSettings and SettingsController classes in a future PR.
Motivation and Context
Cleanup for PP-4 now that almost everything has been converted to use integration settings.
How Has This Been Tested?
Running tests in CI.
Checklist