Clean up dead code in self tests (PP-893) #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1633 +/- ##
=======================================
Coverage 89.61% 89.61%
=======================================
Files 247 247
Lines 28954 28954
Branches 6608 6608
=======================================
Hits 25946 25946
+ Misses 2025 2024 -1
- Partials 983 984 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Remove the now dead HasSelfTests class. Rename HasSelfTestsIntegrationConfiguration to HasSelfTests since it has replaced the HasSelfTests class. Roll up the BaseHasSelfTests class, since its no longer needed. Update the tests to make sure they cover the new HasSelfTests classes.
jonathangreen
force-pushed
the
feature/clean-up-self-tests
branch
from
5f92e1b to
596890a
Compare
jonathangreen
changed the title
tdilauro
approved these changes
Jan 30, 2024
tests/core/test_selftest.py
Outdated
| assert setup.result.called_with_args == () | ||
| assert setup.result.called_with_kwargs == dict( | ||
| extra_extra_arg="foo", extra_arg="a value" | ||
| ) | ||
| assert "a test result" == test.name | ||
|
|
||
| # Since the HasSelfTests object no longer has an associated | ||
| # ExternalIntegration, the test results are not persisted |
There was a problem hiding this comment.
Minor: Update comment?: "ExternalIntegration" -> "Integration"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the now dead
HasSelfTestsclass. RenameHasSelfTestsIntegrationConfigurationtoHasSelfTestssince it has replaced theHasSelfTestsclass. Roll up theBaseHasSelfTestsclass, since its no longer needed.Update the tests to make sure they cover the new
HasSelfTestsclasses.Motivation and Context
Now that all the self tests have been converted over to integration settings in #1627, some of the transitional code to support both integration settings and external integrations can be removed.
How Has This Been Tested?
Running tests in CI.
Checklist