Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in custom list sharing log line. #1631

Merged

Conversation

dbernstein
Copy link
Contributor

Partially resolves: https://ebce-lyrasis.atlassian.net/browse/PP-708

Description

Minor fix to logging line formatting: The code was hitting an unexpected NoneType and blowing up the list sharing routine.

Motivation and Context

https://ebce-lyrasis.atlassian.net/browse/PP-708

How Has This Been Tested?

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bcdad08) 89.89% compared to head (c2b0300) 89.89%.
Report is 5 commits behind head on main.

Files Patch % Lines
core/query/customlist.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1631   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         249      249           
  Lines       29019    29021    +2     
  Branches     6607     6608    +1     
=======================================
+ Hits        26086    26088    +2     
  Misses       1936     1936           
  Partials      997      997           
Flag Coverage Δ
Api 75.87% <33.33%> (-0.01%) ⬇️
Core 58.57% <0.00%> (-0.01%) ⬇️
migration 26.16% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jonathangreen jonathangreen added the bug Something isn't working label Jan 26, 2024
@dbernstein dbernstein merged commit 92f669b into main Jan 26, 2024
27 of 28 checks passed
@dbernstein dbernstein deleted the bugfix/PP-708-fix-logging-error-in-custom-list-sharing-code branch January 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants