Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hold/loan notification times. #1587

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Jan 3, 2024

Description

Change cron configuration for holds/loans notifications script runs from once an hour to once every eight hours.

Motivation and Context

Reduce the impact of the excessive notifications bug described in PP-807.

[Jira PP-808]

How Has This Been Tested?

This change is untested, since our tests do not cover our cron jobs.

Checklist

  • N/A - I have updated the documentation accordingly.
  • N/A - All new and existing tests passed.

@tdilauro tdilauro requested a review from a team January 3, 2024 19:30
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tdilauro tdilauro merged commit 823c611 into main Jan 3, 2024
26 checks passed
@tdilauro tdilauro deleted the feature/change-loan-hold-notification-times branch January 3, 2024 20:39
tdilauro added a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants