Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add report name to the playtime summary attachment filename. #1474

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

dbernstein
Copy link
Contributor

Description

Missed the update to the attachment filename in the first PR.

Motivation and Context

https://ebce-lyrasis.atlassian.net/browse/PP-539

How Has This Been Tested?

Unit test has been updated.

Checklist

  • [/] I have updated the documentation accordingly.
  • [/] All new and existing tests passed.

@dbernstein dbernstein requested a review from tdilauro October 19, 2023 21:57
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54fa9ef) 90.40% compared to head (8e24f89) 90.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1474   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files         230      230           
  Lines       29668    29670    +2     
  Branches     6866     6866           
=======================================
+ Hits        26821    26824    +3     
  Misses       1816     1816           
+ Partials     1031     1030    -1     
Flag Coverage Δ
Api 74.01% <0.00%> (-0.01%) ⬇️
Core 61.10% <100.00%> (+<0.01%) ⬆️
migration 28.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/jobs/playtime_entries.py 98.82% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@jonathangreen jonathangreen added the bug Something isn't working label Oct 20, 2023
@dbernstein dbernstein merged commit 13c4b59 into main Oct 24, 2023
@dbernstein dbernstein deleted the add-report-name-to-time-tracking-csv-filename branch October 24, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants