Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove odilo integration 🔥 (PP-605) #1473

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

jonathangreen
Copy link
Member

Description

Remove the Odilo integration.

Motivation and Context

Slack convo here:
https://lyrasis.slack.com/archives/CCY3PH8JD/p1697744411326959

How Has This Been Tested?

  • Running tests

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🔥

Just need to 🔥 the crontab entry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove the crontab entry for this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! I totally forgot about the crontab entry.

@jonathangreen jonathangreen added the incompatible changes Changes that require a new major version label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b835b0) 90.40% compared to head (4de82b3) 90.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1473      +/-   ##
==========================================
- Coverage   90.40%   90.38%   -0.03%     
==========================================
  Files         230      230              
  Lines       29693    29687       -6     
  Branches     6870     6870              
==========================================
- Hits        26845    26833      -12     
- Misses       1818     1825       +7     
+ Partials     1030     1029       -1     
Flag Coverage Δ
Api 73.94% <ø> (-0.10%) ⬇️
Core 61.11% <ø> (-0.01%) ⬇️
migration 28.97% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/integration/registry/license_providers.py 100.00% <ø> (ø)
core/model/configuration.py 92.30% <ø> (-0.03%) ⬇️
core/model/constants.py 100.00% <ø> (ø)
core/model/datasource.py 88.76% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen merged commit 813eeb1 into main Oct 20, 2023
30 checks passed
@jonathangreen jonathangreen deleted the feature/remove-odilo branch October 20, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible changes Changes that require a new major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants