PP-598 Removed the google analytics provider

[RishiDiwanTT]

Description

Removed the provider along with its test cases

Changed the analytics service test cases to use the s3 provider instead

Motivation and Context

The code didn't work anymore and was deprecated.

How Has This Been Tested?

All unit tests run post removal.

Checklist

• I have updated the documentation accordingly.
• All new and existing tests passed.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e22dade) 90.38% compared to head (3af2cf2) 90.38%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1469   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files         233      232    -1     
  Lines       29713    29663   -50     
  Branches     6794     6786    -8     
=======================================
- Hits        26857    26812   -45     
+ Misses       1823     1817    -6     
- Partials     1033     1034    +1     

Flag	Coverage Δ
Api	74.02% <ø> (-0.05%)	⬇️
Core	61.05% <ø> (+0.10%)	⬆️
migration	28.95% <ø> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
api/admin/controller/analytics_services.py	94.73% <ø> (-1.37%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonathangreen]

This looks good.

The only question / concern I have is: what happens when this code runs against a DB that already has a GA analytics provider configured? Will those settings still show in the admin UI? Will analytics fail to load since the class doesn't exist?

[RishiDiwanTT]

This looks good.

The only question / concern I have is: what happens when this code runs against a DB that already has a GA analytics provider configured? Will those settings still show in the admin UI? Will analytics fail to load since the class doesn't exist?

@jonathangreen It would not hinder the running of the CM as the configuration would have been ignored. I'm not sure about the Admin UI bit. However, I realise leaving the data in the DB as almost no value since this can be reconfigured in case of a rollback.
I've added a migration to remove the google analytics settings.

[jonathangreen]

Looks good