Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing required argument for update_lane_size script (PP-524) #1420

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

jonathangreen
Copy link
Member

Description

Add default of None to _db arg for the update_lane_size script.

Motivation and Context

Working on another issue I noticed that running the update_lane_size script fails with:

Traceback (most recent call last):
  File "bin/update_lane_size", line 11, in <module>
    UpdateLaneSizeScript().run()
TypeError: __init__() missing 1 required positional argument: '_db'

This appears to have come in as part of #1268.

How Has This Been Tested?

Ran script locally.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen added the bug Something isn't working label Oct 2, 2023
@jonathangreen jonathangreen requested a review from a team October 2, 2023 13:48
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (58b43c4) 90.25% compared to head (42d5724) 90.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   90.25%   90.26%           
=======================================
  Files         229      229           
  Lines       29694    29694           
  Branches     6779     6785    +6     
=======================================
+ Hits        26801    26802    +1     
+ Misses       1854     1853    -1     
  Partials     1039     1039           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen changed the title Fix missing required argument for update_lane_size script Fix missing required argument for update_lane_size script (PP-524) Oct 2, 2023
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

Should be good once one of the API test checks re-runs.

@jonathangreen jonathangreen merged commit 9017c23 into main Oct 2, 2023
30 of 31 checks passed
@jonathangreen jonathangreen deleted the bugfix/update-lane-size-script branch October 2, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants