Fix failure to set unlimited_access property on non-existent pool. #1402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simply checks if the pool is not None before trying to set a property on it.
Improves logging to show detailed failure info in logs during OPDS feed imports so that future issues will be easier to troubleshoot in the future.
One thing I'm not sure about: does it make sense for the pool to be returned as a None from
super().update_work_for_e dition
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-192
How Has This Been Tested?
I reran San Rafael BiblioBoard collection locally and confirmed that all 139 failures are no longer occurring.
Checklist