Skip to content

Commit

Permalink
Add Python 3.12 to CI (#2146)
Browse files Browse the repository at this point in the history
* Run tests with Python 3.12

* Add Python 3.12 to CI
  • Loading branch information
jonathangreen authored Oct 30, 2024
1 parent f3568c1 commit fefed3d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.10", "3.11"]
python-version: ["3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v4
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)
[![Imports: isort](https://img.shields.io/badge/%20imports-isort-%231674b1?style=flat&labelColor=ef8336)](https://pycqa.github.io/isort/)
[![pre-commit](https://img.shields.io/badge/pre--commit-enabled-brightgreen?logo=pre-commit&logoColor=white)](https://github.com/pre-commit/pre-commit)
![Python: 3.10,3.11](https://img.shields.io/badge/Python-3.10%20|%203.11-blue)
![Python: 3.10,3.11,3.12](https://img.shields.io/badge/Python-3.10%20|%203.11%20|%203.12-blue)

This is a [The Palace Project](https://thepalaceproject.org) maintained fork of the NYPL
[Library Simplified](http://www.librarysimplified.org/) Circulation Manager.
Expand Down Expand Up @@ -611,6 +611,7 @@ with service dependencies running in docker containers.
|--------|----------------|
| py310 | Python 3.10 |
| py311 | Python 3.11 |
| py312 | Python 3.12 |

All of these environments are tested by default when running tox. To test one specific environment you can use the `-e`
flag.
Expand Down
2 changes: 1 addition & 1 deletion tests/manager/api/controller/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ def test_load_work(self, circulation_fixture: CirculationControllerFixture):
pool1.identifier.type,
pool1.identifier.identifier,
)
work.age_appropriate_for_patron.called_with(
work.age_appropriate_for_patron.assert_called_once_with(
circulation_fixture.default_patron
)

Expand Down
3 changes: 2 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py{310,311}-docker
envlist = py{310,311,312}-docker
skipsdist = true

[testenv]
Expand Down Expand Up @@ -86,3 +86,4 @@ host_var =
python =
3.10: py310
3.11: py311
3.12: py312

0 comments on commit fefed3d

Please sign in to comment.