[PP-2043] Prevent None from displaying when there are no subtitles.

ThePalaceProject · Jan 10, 2025 · ab87ca8 · ab87ca8
1 parent 442d177
commit ab87ca8
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/palace/manager/feed/serializer/opds.py b/src/palace/manager/feed/serializer/opds.py
@@ -163,7 +163,8 @@ def serialize_work_entry(self, feed_entry: WorkEntryData) -> etree._Element:
 
         if feed_entry.title:
             entry.append(OPDSFeed.E("title", feed_entry.title.text))
-        if feed_entry.subtitle:
+
+        if feed_entry.subtitle and feed_entry.subtitle.text:
             entry.append(
                 OPDSFeed.E(
                     f"{{{OPDSFeed.SCHEMA_NS}}}alternativeHeadline",

diff --git a/tests/manager/feed/test_opds_serializer.py b/tests/manager/feed/test_opds_serializer.py
@@ -389,3 +389,21 @@ def test_serialize_facets_and_sort_links_v1(self):
             "{http://palaceproject.io/terms/properties/}default"
             not in facet_link.attrib
         )
+
+    def test_serialize_work_entry_with_subtitle_equals_none(self):
+        data = WorkEntryData(
+            subtitle=FeedEntryType(text=None),
+        )
+
+        element = OPDS1Version1Serializer().serialize_work_entry(data)
+        child = element.findall(f"{{{OPDSFeed.SCHEMA_NS}}}alternativeHeadline")
+        assert len(child) == 0
+
+        data = WorkEntryData(
+            subtitle=FeedEntryType(text="test"),
+        )
+
+        element = OPDS1Version1Serializer().serialize_work_entry(data)
+        child = element.findall(f"{{{OPDSFeed.SCHEMA_NS}}}alternativeHeadline")
+        assert len(child) == 1
+        assert child[0].text == "test"