Fully type hint the OPDS Importer and OPDS2 Importer classes (PP-313) (…

…#1397)

* Add type hinting to OPDS importer class
* Type hint ODL importer classes
* Add type hints for opds for distributors

api/axis.py

@@ -272,7 +272,7 @@ def _count_activity():
             )
 
         # Run the tests defined by HasCollectionSelfTests
-        for result in super()._run_self_tests():
+        for result in super()._run_self_tests(_db):
             yield result
 
     def refresh_bearer_token(self):

api/circulation.py

@@ -435,7 +435,7 @@ def __init__(
         identifier_type: Optional[str],
         identifier: Optional[str],
         start_date: Optional[datetime.datetime],
-        end_date: datetime.datetime,
+        end_date: Optional[datetime.datetime],
         fulfillment_info: Optional[FulfillmentInfo] = None,
         external_identifier: Optional[str] = None,
         locked_to: Optional[DeliveryMechanismInfo] = None,
@@ -752,9 +752,7 @@ def release_hold(self, patron: Patron, pin: str, licensepool: LicensePool) -> No
         ...
 
     @abstractmethod
-    def update_availability(
-        self, licensepool: LicensePool
-    ) -> Tuple[LicensePool, bool, bool]:
+    def update_availability(self, licensepool: LicensePool) -> None:
         """Update availability information for a book."""
         ...
 

api/lcp/hash.py

@@ -1,5 +1,5 @@
 import hashlib
-from abc import ABCMeta, abstractmethod
+from abc import ABC, abstractmethod
 from enum import Enum
 
 from core.exceptions import BaseError
@@ -14,20 +14,19 @@ class HashingError(BaseError):
     """Raised in the case of errors occurred during hashing"""
 
 
-class Hasher(metaclass=ABCMeta):
+class Hasher(ABC):
     """Base class for all implementations of different hashing algorithms"""
 
-    def __init__(self, hashing_algorithm):
+    def __init__(self, hashing_algorithm: HashingAlgorithm) -> None:
         """Initializes a new instance of Hasher class
 
         :param hashing_algorithm: Hashing algorithm
-        :type hashing_algorithm: HashingAlgorithm
         """
         self._hashing_algorithm = hashing_algorithm
 
     @abstractmethod
-    def hash(self, value):
-        raise NotImplementedError()
+    def hash(self, value: str) -> str:
+        ...
 
 
 class UniversalHasher(Hasher):
@@ -49,5 +48,5 @@ def hash(self, value: str) -> str:
 
 
 class HasherFactory:
-    def create(self, hashing_algorithm):
+    def create(self, hashing_algorithm: HashingAlgorithm) -> Hasher:
         return UniversalHasher(hashing_algorithm)