Updates to fix unresolved symbols

src/palace/manager/core/classifier/__init__.py

@@ -13,7 +13,6 @@
 import logging
 import re
 from collections import Counter
-from importlib.resources import files
 
 from sqlalchemy.orm.session import Session
 

src/palace/manager/core/metadata_layer.py

@@ -1856,17 +1856,19 @@ def filter_recommendations(self, _db):
         for identifier in self.recommendations:
             by_type[identifier.type].append(identifier.identifier)
 
-        self.recommendations = []
+        recommendations = set()
         for type, identifiers in list(by_type.items()):
             existing_identifiers = (
                 _db.query(Identifier)
                 .filter(Identifier.type == type)
                 .filter(Identifier.identifier.in_(identifiers))
             )
-            self.recommendations += existing_identifiers.all()
+            recommendations.update(existing_identifiers.all())
 
-        if self.primary_identifier in self.recommendations:
-            self.recommendations.remove(identifier_data)
+        if self.primary_identifier in recommendations:
+            recommendations.remove(self.primary_identifier)
+
+        self.recommendations = list(recommendations)
 
 
 class CSVFormatError(csv.Error):

src/palace/manager/util/personal_names.py

@@ -143,14 +143,6 @@ def is_corporate_name(display_name):
     return False
 
 
-def is_one_name(human_name):
-    """Examples: 'Pope Francis', 'Prince'."""
-    if name.first and not name.last:
-        return True
-
-    return False
-
-
 def display_name_to_sort_name(display_name):
     """
     Take the "First Name Last Name"-formatted display_name, and convert it

tests/manager/api/admin/test_validator.py

@@ -1,11 +1,6 @@
-import pytest
 from werkzeug.datastructures import MultiDict
 
-import palace.manager.sqlalchemy.util
 from palace.manager.api.admin.validator import Validator
-from tests.manager.api.admin.dummy_validator.dummy_validator import (
-    DummyAuthenticationProviderValidator,
-)
 
 
 class MockValidations:
@@ -249,25 +244,3 @@ def test__is_url(self):
         # You can make specific URLs go through even if they
         # wouldn't normally pass.
         assert True == m("Not a URL", ["Not a URL", "Also not a URL"])
-
-
-class PatronAuthenticationValidatorFactoryTest:
-    @pytest.mark.parametrize(
-        "name,protocol",
-        [
-            ("validator_using_class_name", "tests.admin.fixtures.dummy_validator"),
-            (
-                "validator_using_factory_method",
-                "tests.admin.fixtures.dummy_validator_factory",
-            ),
-        ],
-    )
-    def test_create_can_create(self, name, protocol):
-        # Arrange
-        factory = PatronAuthenticationValidatorFactory()
-
-        # Act
-        result = palace.manager.sqlalchemy.util.create(protocol)
-
-        # Assert
-        assert isinstance(result, DummyAuthenticationProviderValidator)

tests/manager/core/test_metadata.py

@@ -1014,10 +1014,21 @@ def test_filter_recommendations(self, db: DatabaseTransactionFixture):
         metadata.filter_recommendations(db.session)
         [result] = metadata.recommendations
         # The IdentifierData has been replaced by a bonafide Identifier.
-        assert True == isinstance(result, Identifier)
-        # The genuwine article.
+        assert isinstance(result, Identifier)
+        # The genuine article.
         assert known_identifier == result
 
+        # Recommendations are filtered to make sure the primary identifier is not recommended.
+        primary_identifier = db.identifier()
+        metadata = Metadata(DataSource.OVERDRIVE, primary_identifier=primary_identifier)
+        metadata.recommendations = [
+            known_identifier_data,
+            unknown_identifier,
+            primary_identifier,
+        ]
+        metadata.filter_recommendations(db.session)
+        assert [known_identifier] == metadata.recommendations
+
     def test_metadata_can_be_deepcopied(self):
         # Check that we didn't put something in the metadata that
         # will prevent it from being copied. (e.g., self.log)