Skip to content

Commit

Permalink
Crush 🪗 core/overdrive.py and api/overdrive.py together (PP-500) (#1436)
Browse files Browse the repository at this point in the history
This refactors the core/overdrive.py and api/overdrive.py files to smash them together. In the process it combines the test fixtures for overdrive from overdrive_fixture, overdrive_with_api_fixture, and overdrive_api_fixture, to just overdrive_api_fixture.
  • Loading branch information
jonathangreen authored Oct 5, 2023
1 parent 3961f6c commit 5484028
Show file tree
Hide file tree
Showing 24 changed files with 2,818 additions and 2,999 deletions.
1,603 changes: 1,581 additions & 22 deletions api/overdrive.py

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bin/informational/overdrive-advantage-accounts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ bin_dir = os.path.split(__file__)[0]
package_dir = os.path.join(bin_dir, "..", "..")
sys.path.append(os.path.abspath(package_dir))

from core.scripts import GenerateOverdriveAdvantageAccountList
from api.overdrive import GenerateOverdriveAdvantageAccountList

GenerateOverdriveAdvantageAccountList().run()
2 changes: 1 addition & 1 deletion bin/informational/overdrive-advantage-list
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ bin_dir = os.path.split(__file__)[0]
package_dir = os.path.join(bin_dir, "..", "..")
sys.path.append(os.path.abspath(package_dir))

from api.overdrive import OverdriveAdvantageAccountListScript # noqa: E402
from api.overdrive import OverdriveAdvantageAccountListScript

OverdriveAdvantageAccountListScript().run()
2 changes: 1 addition & 1 deletion bin/repair/overdrive_bibliographic_coverage
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import sys
bin_dir = os.path.split(__file__)[0]
package_dir = os.path.join(bin_dir, "..", "..")
sys.path.append(os.path.abspath(package_dir))
from core.overdrive import OverdriveBibliographicCoverageProvider
from api.overdrive import OverdriveBibliographicCoverageProvider
from core.scripts import RunCoverageProviderScript

RunCoverageProviderScript(OverdriveBibliographicCoverageProvider).run()
Loading

0 comments on commit 5484028

Please sign in to comment.