Removed more max_cache_age occurrences

core/facets.py

@@ -8,9 +8,6 @@ class FacetConstants:
     ENTRY_POINT_REL = "http://librarysimplified.org/terms/rel/entrypoint"
     ENTRY_POINT_FACET_GROUP_NAME = "entrypoint"
 
-    # Query arguments can change how long a feed is to be cached.
-    MAX_CACHE_AGE_NAME = "max_age"
-
     # Subset the collection, roughly, by quality.
     COLLECTION_FACET_GROUP_NAME = "collection"
     COLLECTION_FULL = "full"

core/lane.py

@@ -82,10 +82,6 @@ class BaseFacets(FacetConstants):
     This is intended solely for use as a base class.
     """
 
-    # By default, faceting objects have no opinion on how long the feeds
-    # generated using them should be cached.
-    max_cache_age = None
-
     def items(self):
         """Yields a 2-tuple for every active facet setting.
 
@@ -146,18 +142,13 @@ class FacetsWithEntryPoint(BaseFacets):
     selected EntryPoint.
     """
 
-    def __init__(
-        self, entrypoint=None, entrypoint_is_default=False, max_cache_age=None, **kwargs
-    ):
+    def __init__(self, entrypoint=None, entrypoint_is_default=False, **kwargs):
         """Constructor.
 
         :param entrypoint: An EntryPoint (optional).
         :param entrypoint_is_default: If this is True, then `entrypoint`
             is a default value and was not determined by a user's
             explicit choice.
-        :param max_cache_age: Any feeds generated by this faceting object
-            will be cached for this amount of time. The default is to have
-            no opinion and let the Worklist manage this.
         :param kwargs: Other arguments may be supplied based on user
             input, but the default implementation is to ignore them.
         """
@@ -297,7 +288,7 @@ def load_entrypoint(cls, name, valid_entrypoints, default=None):
     def items(self):
         """Yields a 2-tuple for every active facet setting.
 
-        In this class that just means the entrypoint and any max_cache_age.
+        In this class that just means the entrypoint.
         """
         if self.entrypoint:
             yield (self.ENTRY_POINT_FACET_GROUP_NAME, self.entrypoint.INTERNAL_NAME)

tests/core/test_lane.py

@@ -92,7 +92,7 @@ def test_navigate(self):
         old_entrypoint = object()
         kwargs = dict(extra_key="extra_value")
         facets = FacetsWithEntryPoint(
-            old_entrypoint, entrypoint_is_default=True, max_cache_age=123, **kwargs
+            old_entrypoint, entrypoint_is_default=True, **kwargs
         )
         new_entrypoint = object()
         new_facets = facets.navigate(new_entrypoint)