PP-529: Material theme #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunommts
reviewed
Oct 11, 2023
| android:minHeight="?attr/actionBarSize" | ||
| android:theme="?android:attr/actionBarTheme" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" |
There was a problem hiding this comment.
Any reason to change the ?attr/actionBarSize to wrap_content ?
There was a problem hiding this comment.
Actually, that should be @dimen/PalaceToolbarHeight. It works correctly now because the theme sets it, but we might as well be extra-explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
This upgrades to the new Material 3 Palace theme.
Why are we doing this? (w/ JIRA link if applicable)
https://ebce-lyrasis.atlassian.net/browse/PP-528
https://ebce-lyrasis.atlassian.net/browse/PP-533
How should this be tested? / Do these changes have associated tests?
Check that the demo application looks and behaves correctly.
Dependencies for merging? Releasing to production?
This shouldn't be merged to production yet! We need to do all of the components (R2, PDF, etc) in one step.
Has the application documentation been updated for these changes?
N/A
Did someone actually run this code to verify it works?
@io7m ran the code a lot in both day and night mode.