Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursion Exercises: Add new factorial exercise #98

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JoshDevHub
Copy link
Contributor

Because

We want to bring the recursion exercises done in the recursion lesson in house.

Link the curriculum issue for this: TheOdinProject/curriculum#27265 (comment)

This PR

  • Adds new exercise for calculating a factorial with recursion.

Issue

Closes #XXXXX

Additional Information

Leaving this as a draft for the time being. The main question I'd have is: are we okay with this organization / structure, or do we want to approach this differently?

Currently all the exercises in this repo are for "basic ruby." It might make sense to create an entirely new repo for these new exercises, which is the same way we do the custom enumerables project.

If we do leave them in this repo, is the way I have them organized here okay? Definitely interested in other maintainer input on the approach here.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Data types exercise: Update spec files
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR includes changes that needs to be updated on the solutions branch, I have created another PR (and linked it to this PR).

@JoshDevHub JoshDevHub marked this pull request as ready for review April 21, 2024 21:43
@JoshDevHub
Copy link
Contributor Author

After discussing with the maintainer team, we agreed to go ahead with this organization, so I've opened this up for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants