Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 06_leapYears README.md with a reference #506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhagyeshsp
Copy link

Because

The present problem statement, borrowed from Chris Pine, does not clearly state the leap year calculation rules, which is indeed confusing.

This PR

  • I updated the README with an external link outlining the nested rules for leap years.

Issue

Closes #XXXXX

Additional Information

Link to the added break-up of the leap years explanation:
https://time-and-calendar.com/leap-years/#:~:text=How%20to%20Know%20if%20Certain%20Year%20is%20a%20Leap%20Year

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the /solutions folder

I updated the README with an external link outlining the nested rules for leap years. The present problem statement, borrowed from Chris Pine, does not clearly state these rules, which is indeed confusing.
To scaffold the learner's journey, it would be useful to add a reference that walks them through the leap year rules with examples. It difficult to stick to the practice exercise if the learner has to shoot in the dark without knowing the exact rules of the game.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant