removes fmt finally and fixes linter

CMakeLists.txt

@@ -68,12 +68,6 @@ add_test(NAME AllTestsInMain COMMAND KeyboardTest)
 # Define the BUILD_DLL macro for the library build
 target_compile_definitions(blink PRIVATE BUILD_DLL)
 
-# fmt dependency
-find_package(fmt CONFIG REQUIRED)
-target_link_libraries(main PRIVATE fmt::fmt)
-target_link_libraries(blink PRIVATE fmt::fmt)
-target_link_libraries(KeyboardTest PRIVATE fmt::fmt)
-
 # Google Benchmark
 find_package(benchmark CONFIG REQUIRED)
 add_executable(KeyboardBenchmark "benchmark/rk84_benchmark.cpp")

src/blink/usb_functions.cpp

@@ -5,7 +5,6 @@
 #include <algorithm>
 
 #include <windows.h>
-#include <fmt/core.h>
 #include <setupapi.h>
 #include <stdio.h>
 #include <hidsdi.h>
@@ -131,7 +130,7 @@ void DoAdditionalUsbThings(HANDLE hDev) {
     HIDP_CAPS capabilities;
     NTSTATUS capsResult = HidP_GetCaps(preparsedData, &capabilities);
     if (capsResult == 0x0011000000)
-        fmt::print("compared...");
+        printf("compared...");
 
     HidD_FreePreparsedData(preparsedData);
 }
@@ -259,7 +258,7 @@ std::vector<KeyboardInfo> ListAvailableKeyboards() {
 
         CloseHandle(hDev);
 
-        for (int i = 0; i < known_keyboards.size(); i++) {
+        for (size_t i = 0; i < known_keyboards.size(); i++) {
             KeyboardInfo known_keyboard = known_keyboards[i];
             if (deviceAttributes.VendorID == known_keyboard.vid && deviceAttributes.ProductID == known_keyboard.pid) {
 

src/demo/choose_keyboard.cpp

@@ -17,7 +17,8 @@ KeyboardInfo ChooseKeyboard() {
 
     std::cout << "Keyboards Available:" << std::endl;
     int i;
-    for (i = 0; i < available_keebs.size(); i++) {
+    int n_available_keebs = available_keebs.size();
+    for (i = 0; i < n_available_keebs; i++) {
         KeyboardInfo keeb = available_keebs[i];
         std::cout << i + 1 << ". " << keeb.display_name
             << " [" << std::hex << keeb.vid << ":" << keeb.pid << "]"

src/demo/main.cpp

@@ -5,7 +5,6 @@
 #include <unordered_map>
 
 #include <windows.h>
-#include <fmt/core.h>
 
 #include "choose_keyboard.h"
 #include "choose_activity.h"

vcpkg.json

@@ -1,6 +1,5 @@
 {
   "dependencies": [
-    "fmt",
     "gtest",
     "benchmark"
   ]