Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MOTIP #82

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Add MOTIP #82

merged 1 commit into from
Sep 29, 2024

Conversation

blake-lowe
Copy link
Contributor

Images for Monsters of the Infinite Planes.

revilowaldow
revilowaldow requested changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@revilowaldow revilowaldow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder name should match the json id of the source. The json id of any new homebrew additions has a minimum length of 6 characters which would be picked up by the tests in the brew repo. Please make sure these match.

@blake-lowe
Copy link
Contributor Author

Hopefully this works, thanks!

"json": "MonstersoftheInfinitePlanes",
"abbreviation": "MotIP",
"full": "Monsters of the Infinite Planes",

revilowaldow
revilowaldow approved these changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@revilowaldow revilowaldow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, cheers

@revilowaldow revilowaldow merged commit 0ac18df into TheGiddyLimit:main Sep 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revilowaldow revilowaldow revilowaldow approved these changes

@TheGiddyLimit TheGiddyLimit Awaiting requested review from TheGiddyLimit TheGiddyLimit is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blake-lowe @revilowaldow