-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Br meettheprogramcoordinator #31
base: beta
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,64 @@ | |||
* { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this rule set
font-family: 'Open Sans', sans-serif; | ||
} | ||
|
||
.box-content { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to be name spaced. ie. brroots-box-content
background-color: #fff; | ||
color: #272b34; | ||
} | ||
.box-content { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combine these rules
margin-bottom: 250px; | ||
background-color: inherit; | ||
} | ||
.br-left > h1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a class on that h1 instead of this selector
text-transform: uppercase; | ||
} | ||
|
||
button { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a class to the button
s and reference that classname here
.br-right { | ||
margin-top: 25px; | ||
} | ||
img { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule is too general. We'll need to use a classname on that image and reference here.
margin-left: 25%; | ||
margin-right: 25%; | ||
}/* | ||
.br-right, img { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete commented rules
.flex-placeholder { | ||
flex: 1; | ||
} | ||
.br-left { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update indentation
@@ -0,0 +1,11 @@ | |||
<div class = "box-content"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update classname to be namespaced to reduce possible conflicts with the whole
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments in!
Issue #21 hotfix.