Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Br meettheprogramcoordinator #31

Open
wants to merge 8 commits into
base: beta
Choose a base branch
from

Conversation

DamienVesper
Copy link
Collaborator

Issue #21 hotfix.

@DamienVesper DamienVesper added enhancement New feature or request. html Requires Hyper Text Markup Language editing. css Requires Cascading Style Sheets editing. labels Mar 16, 2019
@DamienVesper DamienVesper self-assigned this Mar 16, 2019
@@ -0,0 +1,64 @@
* {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this rule set

font-family: 'Open Sans', sans-serif;
}

.box-content {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to be name spaced. ie. brroots-box-content

background-color: #fff;
color: #272b34;
}
.box-content {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine these rules

margin-bottom: 250px;
background-color: inherit;
}
.br-left > h1 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a class on that h1 instead of this selector

text-transform: uppercase;
}

button {
Copy link
Collaborator

@QuintonJason QuintonJason Mar 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a class to the buttons and reference that classname here

.br-right {
margin-top: 25px;
}
img {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is too general. We'll need to use a classname on that image and reference here.

margin-left: 25%;
margin-right: 25%;
}/*
.br-right, img {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete commented rules

.flex-placeholder {
flex: 1;
}
.br-left {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update indentation

@@ -0,0 +1,11 @@
<div class = "box-content">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update classname to be namespaced to reduce possible conflicts with the whole

Copy link
Collaborator

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Requires Cascading Style Sheets editing. enhancement New feature or request. html Requires Hyper Text Markup Language editing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants