Attempting Patch #101
Merged
Attempting Patch #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GillesC time to merge? No-one has complained! :) |
|
Let's merge it! :)
…On 05 Jan 2018 12:04, "Alok Rajiv" ***@***.***> wrote:
@GillesC <https://github.com/gillesc> time to merge?
No-one has complained! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIOhi2uT8g-rPgaViGIPtMKckXZ-UalWks5tHgGfgaJpZM4QwFB->
.
|
|
@alokrajiv @GillesC Thanks for your efforts. |
|
@Maziar-Fotouhi I think soon we will have to push a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soln proposed by @sum1190
Issue #88
cc @Maziar-Fotouhi
@GillesC can you check all test cases.