-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate cargo-generate
branch updates
#263
Automate cargo-generate
branch updates
#263
Conversation
This reverts commit a64b82c.
Thanks, Jan! Co-authored-by: Jan Hohenheim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate all the comments in the workflow :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The double quotes / curly braces are technically not required here, but it's good form to use them anyways to avoid subtle bugs in situations where they are required, or if assumptions are invalidated in the future.
PR seems reasonable to me otherwise. We can test it out in practice and fix issues if any arise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than @benfrankel's comments
Co-authored-by: Ben Frankel <[email protected]>
Closes #129.
This adds
cargo-generate.yaml
, a workflow that will automatically merge new changes frommain
to thecargo-generate
branch.This will require someone with write access to this repo to create a personal access token with write permissions for "Contents" and "Workflows". I cannot use my own, since I don't have write access. I recommend creating a scoped token that can only write to this specific repository.
This workflow will automatically create an issue on a merge conflict. For an example, see https://github.com/BD103/bevy_quickstart/issues/4.