Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make YAML indent size 2 in .editorconfig #261

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Make YAML indent size 2 in .editorconfig #261

merged 1 commit into from
Aug 11, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Aug 11, 2024

This makes the indent size for YAML files in .github/workflows 2 spaces, as compared to 4. While YAML can technically support any indent size, all of the existing workflows in this repository already use 2 spaces. Furthermore, I had parsing issues in the past using 4 with Github Actions. (I'm unsure if it's a user-error on my part, or some specific of Github Actions.)

Copy link
Collaborator

@benfrankel benfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Doing this manually has been pretty annoying, and lots of false positive red highlights on "bad indentation". Hopefully this helps with those? Either way makes sense.

EDIT: Yes it's good now.

@benfrankel benfrankel merged commit fc593b7 into TheBevyFlock:main Aug 11, 2024
4 checks passed
@BD103 BD103 deleted the editorconfig-yml branch August 11, 2024 02:42
benfrankel pushed a commit to benfrankel/bevy_new_2d that referenced this pull request Aug 11, 2024
This makes the indent size for YAML files in `.github/workflows` 2
spaces, as compared to 4. While YAML can technically support any indent
size, all of the existing workflows in this repository already use 2
spaces. Furthermore, I had parsing issues in the past using 4 with
Github Actions. (I'm unsure if it's a user-error on my part, or some
specific of Github Actions.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants