Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the underFlow bug in src/binarySearch.sol #86

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

Adi9876
Copy link
Contributor

@Adi9876 Adi9876 commented Oct 2, 2023

@Panquesito7 @mkubdev Fixed the bug for underflow in the contract !!

@Adi9876 Adi9876 requested a review from mkubdev as a code owner October 2, 2023 18:02
@Panquesito7 Panquesito7 linked an issue Oct 4, 2023 that may be closed by this pull request
@Panquesito7 Panquesito7 added the bug Something isn't working label Oct 4, 2023
@Adi9876
Copy link
Contributor Author

Adi9876 commented Oct 5, 2023

@mkubdev please review it and update me if any issues

@Adi9876
Copy link
Contributor Author

Adi9876 commented Oct 21, 2023

@mkubdev @Panquesito7 any updates !!

Copy link
Member

@mkubdev mkubdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkubdev mkubdev merged commit 7e4dfc8 into TheAlgorithms:main Oct 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Possible underflow in binary search
3 participants