Jumper insertion: modifications in DRT and ODB #6138

luis201420 · 2024-11-11T19:15:31Z

Fixes The-OpenROAD-Project/OpenROAD-flow-scripts#2477
It contains the modifications required to use jumper insertion in the flow.
ODB:

Added a flag in dbNet to check if a net has jumpers in its guide.
Added a flag in dbGuide to check if the guide is a jumper.

DRT:

Using the dbNet flag to increase the cost of not using a guide when routing a net with a jumper.

GRT:

Running jumper insertion in repair antenna iterations when you have new nets with a violation.

Results:
I ran a test-branch with the modifications, the reduction of diodes for sky130hd are:

aes:
GRT diodes: from 190 to 138
DRT diodes: from 8 to 13
Total diodes: from 198 to 151 (23.74%)
chameleon:
GRT diodes: from 429 to 108
DRT diodes: from 38 to 108
Total diodes: from 467 to 216 (53.75%)
jpeg:
GRT diodes: from 234 to 61
DRT diodes: from 49 to 64
Total diodes: from 283 to 125 (55.83%)
ibex:
GRT diodes: from 113 to 51
DRT diodes: from 35 to 47
Total diodes: from 148 to 98 (33.8%)
microwatt:
GRT diodes: from 7205 to 4163
DRT diodes: from 1379 to 1849
Total diodes: from 8584 to 6012 (30%)
This design is ending with 3 antenna violations after DRT.

Future works:

Use the dbGuide flag in DRT to increase the cost of not using guides when routing a guide.
Improve jumper insertion to reduce the number of diodes used.

Signed-off-by: luis201420 <[email protected]>

github-actions · 2024-11-11T19:36:33Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-11-11T19:48:58Z

clang-tidy review says "All clean, LGTM! 👍"

src/odb/src/db/dbGuide.h

Signed-off-by: luis201420 <[email protected]>

github-actions · 2024-11-12T03:55:13Z

clang-tidy review says "All clean, LGTM! 👍"

eder-matheus

@luis201420 Please look at the regression errors too.

src/drt/src/dr/FlexDR_maze.cpp

src/drt/src/db/obj/frNet.h

src/drt/src/dr/FlexGridGraph_maze.cpp

eder-matheus · 2024-11-13T21:02:19Z

src/drt/src/db/obj/frNet.h

@@ -272,6 +274,7 @@ class frNet : public frBlockObject
  bool hasInitialRouting_{false};
  bool isFixed_{false};

+  bool hasJumpers_{false};


Add a comment explaining what is the jumper in this context.

src/grt/src/RepairAntennas.cpp

eder-matheus · 2024-11-13T21:12:00Z

src/grt/src/RepairAntennas.h

@@ -214,6 +214,7 @@ class RepairAntennas
  void destroyNetWires(const std::vector<odb::dbNet*>& nets_to_repair);
  odb::dbMTerm* findDiodeMTerm();
  double diffArea(odb::dbMTerm* mterm);
+  bool runJumperInsertion() { return run_jumper_insertion_; }


This function name can mislead to what it actually does. Maybe instead of run... you can use isJumperInsertion.

eder-matheus · 2024-11-13T21:12:11Z

src/grt/src/RepairAntennas.h

@@ -295,6 +296,7 @@ class RepairAntennas
  AntennaViolations antenna_violations_;
  int unique_diode_index_;
  int illegal_diode_placement_count_;
+  bool run_jumper_insertion_;


Same for the class member name.

Signed-off-by: luis201420 <[email protected]>

github-actions · 2024-11-15T17:12:09Z

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: luis201420 <[email protected]>

github-actions · 2024-11-18T17:10:41Z

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: luis201420 <[email protected]>

github-actions · 2024-11-18T20:13:30Z

clang-tidy review says "All clean, LGTM! 👍"

src/drt/src/db/obj/frNet.h

Signed-off-by: luis201420 <[email protected]>

eder-matheus

@luis201420 Please start a new ecure-ci run to ensure it will not break any design.

Signed-off-by: luis201420 <[email protected]>

github-actions · 2024-11-18T21:24:10Z

clang-tidy review says "All clean, LGTM! 👍"

luis201420 · 2024-11-18T23:00:24Z

@luis201420 Please start a new ecure-ci run to ensure it will not break any design.

Ok, I ran a new secure-ci to verify the designs.

github-actions · 2024-11-18T23:19:23Z

clang-tidy review says "All clean, LGTM! 👍"

luis201420 added 27 commits October 19, 2024 15:05

odb: adding has_jumpers flag in dbNet

426e936

Signed-off-by: luis201420 <[email protected]>

drt: using has_jumpers flag to increase the guide cost

c54c317

Signed-off-by: luis201420 <[email protected]>

grt: using jumper insertion and set has_jumpers flag

b894f2c

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

d67b15f

Signed-off-by: luis201420 <[email protected]>

drt: increasing the jumper cost

9d77600

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

1b95a23

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

405041a

Signed-off-by: luis201420 <[email protected]>

grt: running jumper insertion when there are new nets to repair

71cbe41

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

a8f032c

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

38fe8bd

Signed-off-by: luis201420 <[email protected]>

drt: adding clang-format

91278bd

Signed-off-by: luis201420 <[email protected]>

grt: adding clang-format

4e3fd2f

Signed-off-by: luis201420 <[email protected]>

odb: adding comment for jumper insertion schema

c01575b

Signed-off-by: luis201420 <[email protected]>

odb: adding flag to mark guides that are jumpers

dd52984

Signed-off-by: luis201420 <[email protected]>

grt: using flag to mark jumper guides

5879673

Signed-off-by: luis201420 <[email protected]>

drt: checking the number of jumper guides

765bcca

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

27ceab3

Signed-off-by: luis201420 <[email protected]>

drt: finding nets with jumpers

153481e

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

05327be

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

cc3a830

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

a41af71

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

5c01269

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

71ceb0f

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

886627f

Signed-off-by: luis201420 <[email protected]>

drt: removing debug code

434f182

Signed-off-by: luis201420 <[email protected]>

grt: removing debug code

1c4efbe

Signed-off-by: luis201420 <[email protected]>

grt: adding clang format

666ab85

Signed-off-by: luis201420 <[email protected]>

luis201420 requested a review from eder-matheus November 11, 2024 19:15

luis201420 marked this pull request as draft November 11, 2024 19:15

luis201420 marked this pull request as ready for review November 11, 2024 19:16

luis201420 marked this pull request as draft November 11, 2024 19:16

Merge remote-tracking branch 'origin' into drt_jumper_insertion

9a54355

Signed-off-by: luis201420 <[email protected]>

eder-matheus reviewed Nov 11, 2024

View reviewed changes

src/odb/src/db/dbGuide.h Outdated Show resolved Hide resolved

odb: adding is_jumper flag to dbGuide

25bfb2b

Signed-off-by: luis201420 <[email protected]>

eder-matheus requested changes Nov 13, 2024

View reviewed changes

luis201420 added 2 commits November 14, 2024 02:57

Merge remote-tracking branch 'origin' into drt_jumper_insertion

84a2560

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

03267d7

Signed-off-by: luis201420 <[email protected]>

luis201420 added 2 commits November 18, 2024 16:48

grt: running jumper insertion for each antenna violation of a net

3c40cad

Signed-off-by: luis201420 <[email protected]>

Merge remote-tracking branch 'origin' into drt_jumper_insertion

a4d1930

Signed-off-by: luis201420 <[email protected]>

luis201420 added 2 commits November 18, 2024 19:50

drt: adding requested changes

1707cad

Signed-off-by: luis201420 <[email protected]>

grt: adding requested changes

265e4ac

Signed-off-by: luis201420 <[email protected]>

eder-matheus requested changes Nov 18, 2024

View reviewed changes

src/drt/src/db/obj/frNet.h Outdated Show resolved Hide resolved

luis201420 added 3 commits November 18, 2024 20:37

grt: updating unit tests

9c512f9

Signed-off-by: luis201420 <[email protected]>

updating ibex_sky130hd and jpeg_sky130hd tests

1bad828

Signed-off-by: luis201420 <[email protected]>

drt: adding comment with a brief explanation about what is a jumper

460b4f8

Signed-off-by: luis201420 <[email protected]>

eder-matheus approved these changes Nov 18, 2024

View reviewed changes

Merge remote-tracking branch 'origin' into drt_jumper_insertion

1cb0909

Signed-off-by: luis201420 <[email protected]>

luis201420 marked this pull request as ready for review November 18, 2024 23:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jumper insertion: modifications in DRT and ODB #6138

Jumper insertion: modifications in DRT and ODB #6138

luis201420 commented Nov 11, 2024 •

edited

Loading

github-actions bot commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

github-actions bot commented Nov 12, 2024

eder-matheus left a comment

eder-matheus Nov 13, 2024

eder-matheus Nov 13, 2024

eder-matheus Nov 13, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

eder-matheus left a comment

github-actions bot commented Nov 18, 2024

luis201420 commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

Jumper insertion: modifications in DRT and ODB #6138

Are you sure you want to change the base?

Jumper insertion: modifications in DRT and ODB #6138

Conversation

luis201420 commented Nov 11, 2024 • edited Loading

github-actions bot commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

github-actions bot commented Nov 12, 2024

eder-matheus left a comment

Choose a reason for hiding this comment

eder-matheus Nov 13, 2024

Choose a reason for hiding this comment

eder-matheus Nov 13, 2024

Choose a reason for hiding this comment

eder-matheus Nov 13, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

eder-matheus left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 18, 2024

luis201420 commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

luis201420 commented Nov 11, 2024 •

edited

Loading