Cts enable obstruction aware #5900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) treat clock gaters like macro cell instances 2) need to change arrival computation Signed-off-by: Cho Moon <[email protected]>
1) arrival computation is now recursive 2) latency adjustments are made from bottom up Signed-off-by: Cho Moon <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthurjolo <[email protected]>
Signed-off-by: arthurjolo <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
Signed-off-by: arthur <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -247,6 +247,12 @@ class TreeBuilder | |||
| void setTopBufferDelay(float delay) { topBufferDelay_ = delay; } | |||
| odb::dbInst* getTopBuffer() const { return topBuffer_; } | |||
| void setTopBuffer(odb::dbInst* inst) { topBuffer_ = inst; } | |||
| std::string getTopBufferName() const { return topBufferName_; } | |||
| void setTopBufferName(std::string name) { topBufferName_ = name; } | |||
There was a problem hiding this comment.
warning: parameter 'name' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
src/cts/src/TreeBuilder.h:43:
- #include <vector>
+ #include <utility>
+ #include <vector>
Suggested change
| void setTopBufferName(std::string name) { topBufferName_ = name; } | |
| void setTopBufferName(std::string name) { topBufferName_ = std::move(name); } |
| pathStartNet = port->getNet(); | ||
| } | ||
| if (pathStartNet == topNet) { | ||
| clkPathArrival = path->arrival(openSta_); |
There was a problem hiding this comment.
warning: Value stored to 'pathsAccepted' is never read [clang-analyzer-deadcode.DeadStores]
pathsAccepted += 1;
^Additional context
src/cts/src/TritonCTS.cpp:2117: Value stored to 'pathsAccepted' is never read
pathsAccepted += 1;
^
src/cts/src/TritonCTS.cpp
Outdated
Comment on lines
2200
to
2217
| return; | ||
| } else { | ||
| // not a sink, but a clock gater | ||
| odb::dbITerm* outTerm = inst->getFirstOutput(); | ||
| if (outTerm) { | ||
| odb::dbNet* outNet = outTerm->getNet(); | ||
| if (outNet) { | ||
| odb::dbSet<odb::dbITerm> iterms = outNet->getITerms(); | ||
| odb::dbSet<odb::dbITerm>::iterator iter; | ||
| for (iter = iterms.begin(); iter != iterms.end(); ++iter) { | ||
| odb::dbITerm* inTerm = *iter; | ||
| if (inTerm->getIoType() == odb::dbIoType::INPUT) { | ||
| computeSinkArrivalRecur( | ||
| topClokcNet, inTerm, sumArrivals, numSinks, graph); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [readability-else-after-return]
Suggested change
| return; | |
| } else { | |
| // not a sink, but a clock gater | |
| odb::dbITerm* outTerm = inst->getFirstOutput(); | |
| if (outTerm) { | |
| odb::dbNet* outNet = outTerm->getNet(); | |
| if (outNet) { | |
| odb::dbSet<odb::dbITerm> iterms = outNet->getITerms(); | |
| odb::dbSet<odb::dbITerm>::iterator iter; | |
| for (iter = iterms.begin(); iter != iterms.end(); ++iter) { | |
| odb::dbITerm* inTerm = *iter; | |
| if (inTerm->getIoType() == odb::dbIoType::INPUT) { | |
| computeSinkArrivalRecur( | |
| topClokcNet, inTerm, sumArrivals, numSinks, graph); | |
| } | |
| } | |
| } | |
| } | |
| } // not a sink, but a clock gater | |
| odb::dbITerm* outTerm = inst->getFirstOutput(); | |
| if (outTerm) { | |
| odb::dbNet* outNet = outTerm->getNet(); | |
| if (outNet) { | |
| odb::dbSet<odb::dbITerm> iterms = outNet->getITerms(); | |
| odb::dbSet<odb::dbITerm>::iterator iter; | |
| for (iter = iterms.begin(); iter != iterms.end(); ++iter) { | |
| odb::dbITerm* inTerm = *iter; | |
| if (inTerm->getIoType() == odb::dbIoType::INPUT) { | |
| computeSinkArrivalRecur( | |
| topClokcNet, inTerm, sumArrivals, numSinks, graph); | |
| } | |
| } | |
| } | |
| } | |
Comment on lines
+2220
to
+2221
| } | ||
| return; |
There was a problem hiding this comment.
warning: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow]
Suggested change
| } | |
| return; | |
| } |
src/cts/src/TritonCTS.cpp
Outdated
| } | ||
| if (pathStartNet == topNet) { | ||
| clkPathArrival = path->arrival(openSta_); | ||
| pathsAccepted += 1; |
There was a problem hiding this comment.
warning: Value stored to 'pathsAccepted' is never read [clang-analyzer-deadcode.DeadStores]
pathsAccepted += 1;
^Additional context
src/cts/src/TritonCTS.cpp:2118: Value stored to 'pathsAccepted' is never read
pathsAccepted += 1;
^
Comment on lines
+2201
to
+2218
| } else { | ||
| // not a sink, but a clock gater | ||
| odb::dbITerm* outTerm = inst->getFirstOutput(); | ||
| if (outTerm) { | ||
| odb::dbNet* outNet = outTerm->getNet(); | ||
| if (outNet) { | ||
| odb::dbSet<odb::dbITerm> iterms = outNet->getITerms(); | ||
| odb::dbSet<odb::dbITerm>::iterator iter; | ||
| for (iter = iterms.begin(); iter != iterms.end(); ++iter) { | ||
| odb::dbITerm* inTerm = *iter; | ||
| if (inTerm->getIoType() == odb::dbIoType::INPUT) { | ||
| computeSinkArrivalRecur( | ||
| topClokcNet, inTerm, sumArrivals, numSinks, graph); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [readability-else-after-return]
Suggested change
| } else { | |
| // not a sink, but a clock gater | |
| odb::dbITerm* outTerm = inst->getFirstOutput(); | |
| if (outTerm) { | |
| odb::dbNet* outNet = outTerm->getNet(); | |
| if (outNet) { | |
| odb::dbSet<odb::dbITerm> iterms = outNet->getITerms(); | |
| odb::dbSet<odb::dbITerm>::iterator iter; | |
| for (iter = iterms.begin(); iter != iterms.end(); ++iter) { | |
| odb::dbITerm* inTerm = *iter; | |
| if (inTerm->getIoType() == odb::dbIoType::INPUT) { | |
| computeSinkArrivalRecur( | |
| topClokcNet, inTerm, sumArrivals, numSinks, graph); | |
| } | |
| } | |
| } | |
| } | |
| } | |
| } // not a sink, but a clock gater | |
| odb::dbITerm* outTerm = inst->getFirstOutput(); | |
| if (outTerm) { | |
| odb::dbNet* outNet = outTerm->getNet(); | |
| if (outNet) { | |
| odb::dbSet<odb::dbITerm> iterms = outNet->getITerms(); | |
| odb::dbSet<odb::dbITerm>::iterator iter; | |
| for (iter = iterms.begin(); iter != iterms.end(); ++iter) { | |
| odb::dbITerm* inTerm = *iter; | |
| if (inTerm->getIoType() == odb::dbIoType::INPUT) { | |
| computeSinkArrivalRecur( | |
| topClokcNet, inTerm, sumArrivals, numSinks, graph); | |
| } | |
| } | |
| } | |
| } | |
Comment on lines
+2221
to
+2222
| return; | ||
| } |
There was a problem hiding this comment.
warning: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow]
Suggested change
| return; | |
| } | |
| } |
|
Secure-CI is has few metrics failures and a PR has been created to update them, a7/mock_array and ng45/bp_fe have degradation on timing metrics due to a bad placement decision from obstruction aware, I am already working on fixing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the CTS option -obstruction_aware and enables it by default, and adds improvements to prevent metrics degradation: