mpl2: finalization of memory management rework #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Koucher <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Arthur Koucher <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Arthur Koucher <[email protected]>
AcKoucher
force-pushed
the
mpl2-cluster-memory
branch
from
576ef6b
to
8a05938
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Arthur Koucher <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@maliberty I'm running some tests with valgrind and will also start a secure-CI. With that in mind, this is ready for review. |
Signed-off-by: Arthur Koucher <[email protected]>
AcKoucher
force-pushed
the
mpl2-cluster-memory
branch
from
f026a07
to
06b58c1
Compare
|
I force pushed just to fix the last commit message. |
maliberty
reviewed
Aug 8, 2024
Signed-off-by: Arthur Koucher <[email protected]>
|
Done Secure-CI didn't show problems and valgrind is clean. |
maliberty
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clusters now own their children in such a way that destroying the root will destroy all other clusters up to the leaves.