Add support to LEF58_MAXSPACING in ODB and DRT #5287

openroad-robot · 2024-06-25T22:42:29Z

In this PR:

Support LEF58_MAXSPACING in ODB with necessary tests
Support LEF58_MAXSPACING in DRT database
Set a secondary via def for each cut layer that has a different cutclass than the default
Detect lonely vias after routing according the LEF58_MAXSPACING rule
Substitute all lonely vias with a secondary via
Patching minstep resulting from secondary via defs in GC

Signed-off-by: osamahammad21 <[email protected]>

…te/OpenROAD into TR-maxspacing

Signed-off-by: osamahammad21 <[email protected]>

Signed-off-by: Osama <[email protected]>

github-actions

clang-tidy made some suggestions

src/drt/src/db/infra/KDTree.cpp

src/drt/src/db/infra/KDTree.hpp

src/drt/src/frRegionQuery.cpp

github-actions · 2024-06-25T23:16:40Z

src/odb/src/db/dbTechLayerMaxSpacingRule.cpp

+{
+  _dbTechLayerMaxSpacingRule* obj = (_dbTechLayerMaxSpacingRule*) this;
+
+  obj->cut_class_ = cut_class;


warning: parameter 'cut_class' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]

src/odb/src/db/dbTechLayerMaxSpacingRule.cpp:34:

+ + #include <utility>

Suggested change

obj->cut_class_ = cut_class;

obj->cut_class_ = std::move(cut_class);

github-actions · 2024-06-25T23:16:40Z

src/odb/src/lefin/MaxSpacingParser.cpp

+#include "odb/db.h"
+#include "odb/lefin.h"
+
+using namespace odb;


warning: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace]

using namespace odb; ^

Signed-off-by: osamahammad21 <[email protected]>

Signed-off-by: Osama <[email protected]>

Signed-off-by: osamahammad21 <[email protected]>

Signed-off-by: Osama <[email protected]>

Signed-off-by: osamahammad21 <[email protected]>

osamahammad21 · 2024-07-29T14:35:05Z

@maliberty Passes all CIs. Ready for review

github-actions

clang-tidy made some suggestions

src/drt/src/dr/FlexDR_maze.cpp

src/drt/src/io/io_parser_helper.cpp

maliberty · 2024-07-29T15:18:10Z

Please resolve the clang-tidy

maliberty

I'll review the KDTree once I understand why it is necessary

src/odb/src/lefin/MaxSpacingParser.cpp

src/drt/src/io/io_parser_helper.cpp

src/drt/src/TritonRoute.tcl

maliberty · 2024-07-29T15:29:10Z

src/drt/src/dr/FlexDR.cpp

+  for (auto [obj, box] : vias) {
+    via_positions.emplace_back(box.xCenter(), box.yCenter());
+  }
+  KDTree tree(via_positions);


Why not use a boost rtree?

src/drt/src/dr/FlexDR.cpp

src/drt/src/io/io_parser_helper.cpp

Signed-off-by: osamahammad21 <[email protected]>

src/odb/src/db/dbTechLayerMaxSpacingRule.cpp

Signed-off-by: osamahammad21 <[email protected]>

osamahammad21 · 2024-08-05T01:20:50Z

@maliberty Can we merge this?

src/drt/src/dr/FlexDR.cpp

Signed-off-by: osamahammad21 <[email protected]>

src/drt/src/dr/FlexDR.cpp

src/drt/src/db/infra/KDTree.hpp

src/drt/src/db/infra/KDTree.cpp

Signed-off-by: osamahammad21 <[email protected]>

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-06T16:07:20Z

src/drt/src/db/infra/KDTree.hpp

+#include "frBaseTypes.h"
+#include "odb/geom.h"
+
+using odb::Orientation2D;


warning: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers]

using odb::Orientation2D; ^

github-actions · 2024-08-06T16:07:20Z

src/drt/src/db/infra/KDTree.hpp

+#include "odb/geom.h"
+
+using odb::Orientation2D;
+using odb::Point;


warning: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers]

using odb::Point; ^

github-actions · 2024-08-06T16:07:20Z

src/drt/src/db/infra/KDTree.hpp

+
+  void radiusSearchHelper(KDTreeNode* node,
+                          const Point& target,
+                          const frSquaredDistance radius_square,


warning: parameter 'radius_square' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]

Suggested change

const frSquaredDistance radius_square,

frSquaredDistance radius_square,

osamahammad21 added 10 commits May 26, 2024 21:03

odb: support LEF58_MAXSPACING

2c3909e

Signed-off-by: osamahammad21 <[email protected]>

drt: support and fix LEF58_MAXSPACING

cfcd36f

Signed-off-by: osamahammad21 <[email protected]>

odb: db_schema_max_spacing

3f17351

Signed-off-by: osamahammad21 <[email protected]>

drt: fixes for max_spacing support

bc4e6d7

Signed-off-by: osamahammad21 <[email protected]>

odb: update lefok

9018ca7

Signed-off-by: osamahammad21 <[email protected]>

drt: patch minstep from secondaryViaDef

adafa6e

Signed-off-by: osamahammad21 <[email protected]>

Merge remote-tracking branch 'origin/master' into TR-maxspacing

d394be5

Merge branch 'TR-maxspacing' of github.com:The-OpenROAD-Project-priva…

418be72

…te/OpenROAD into TR-maxspacing

drt: fix build warnings

e0938ed

Signed-off-by: osamahammad21 <[email protected]>

Merge remote-tracking branch 'origin/master' into TR-maxspacing

1fae110

Signed-off-by: Osama <[email protected]>

osamahammad21 marked this pull request as ready for review June 25, 2024 22:51

osamahammad21 requested a review from maliberty June 25, 2024 22:52

github-actions bot reviewed Jun 25, 2024

View reviewed changes

osamahammad21 added 12 commits June 27, 2024 18:37

Merge remote-tracking branch 'origin/master' into TR-maxspacing

f86b070

drt: fix cut enclosure eol on secondary viadef

6548d3f

Signed-off-by: osamahammad21 <[email protected]>

Merge remote-tracking branch 'origin/master' into TR-maxspacing

231b06c

Merge remote-tracking branch 'origin/master' into TR-maxspacing

8cf9420

Merge remote-tracking branch 'origin/master' into TR-maxspacing

4390d75

drt: generate secondaryViaDef on DISABLE_VIA_GEN

48eaa86

Signed-off-by: Osama <[email protected]>

drt: new strategy for LEF58_MAXSPACING handling

ef050ff

Signed-off-by: osamahammad21 <[email protected]>

Merge remote-tracking branch 'origin/master' into TR-maxspacing

d240fb9

Signed-off-by: Osama <[email protected]>

drt: merge updates

391872b

Signed-off-by: Osama <[email protected]>

drt: cleanup

69dc5c8

Signed-off-by: Osama <[email protected]>

drt: cleanup

b39bc5d

Signed-off-by: osamahammad21 <[email protected]>

Merge remote-tracking branch 'origin/master' into TR-maxspacing

a5f2f36

github-actions bot reviewed Jul 29, 2024

View reviewed changes

maliberty requested changes Jul 29, 2024

View reviewed changes

drt: fix_max_spacing cmd

977db46

Signed-off-by: osamahammad21 <[email protected]>

osamahammad21 added 2 commits August 2, 2024 17:09

drt: clang-tidy requested changes

1b17b3f

Signed-off-by: osamahammad21 <[email protected]>

odb: PII copyrights

dc975bd

Signed-off-by: osamahammad21 <[email protected]>

osamahammad21 reviewed Aug 2, 2024

View reviewed changes

src/odb/src/db/dbTechLayerMaxSpacingRule.cpp Show resolved Hide resolved

osamahammad21 requested a review from maliberty August 2, 2024 14:22

osamahammad21 added 2 commits August 5, 2024 01:26

Merge remote-tracking branch 'origin/master' into TR-maxspacing

8066100

odb: generate

1fe4b08

Signed-off-by: osamahammad21 <[email protected]>

maliberty reviewed Aug 5, 2024

View reviewed changes

src/drt/src/dr/FlexDR.cpp Outdated Show resolved Hide resolved

drt: parallelization changes

84322f6

Signed-off-by: osamahammad21 <[email protected]>

osamahammad21 requested a review from maliberty August 5, 2024 18:39

maliberty requested changes Aug 5, 2024

View reviewed changes

src/drt/src/dr/FlexDR.cpp Outdated Show resolved Hide resolved

maliberty requested changes Aug 5, 2024

View reviewed changes

osamahammad21 added 2 commits August 6, 2024 17:05

drt: required updates in KDTree

7de464f

Signed-off-by: osamahammad21 <[email protected]>

Merge remote-tracking branch 'origin/master' into TR-maxspacing

b40dfbc

Signed-off-by: osamahammad21 <[email protected]>

osamahammad21 requested a review from maliberty August 6, 2024 15:19

maliberty approved these changes Aug 6, 2024

View reviewed changes

maliberty enabled auto-merge August 6, 2024 15:22

maliberty merged commit 28f8d02 into The-OpenROAD-Project:master Aug 6, 2024
10 checks passed

maliberty deleted the TR-maxspacing branch August 6, 2024 15:48

github-actions bot reviewed Aug 6, 2024

View reviewed changes

osamahammad21 mentioned this pull request Aug 6, 2024

DRT: Support LEF58_MAXSPACING and fix lonely vias #5267

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to LEF58_MAXSPACING in ODB and DRT #5287

Add support to LEF58_MAXSPACING in ODB and DRT #5287

openroad-robot commented Jun 25, 2024

github-actions bot left a comment

github-actions bot Jun 25, 2024

github-actions bot Jun 25, 2024

osamahammad21 commented Jul 29, 2024

github-actions bot left a comment

maliberty commented Jul 29, 2024

maliberty left a comment

maliberty Jul 29, 2024

osamahammad21 commented Aug 5, 2024

github-actions bot left a comment

github-actions bot Aug 6, 2024

github-actions bot Aug 6, 2024

github-actions bot Aug 6, 2024

	obj->cut_class_ = cut_class;
	obj->cut_class_ = std::move(cut_class);

	const frSquaredDistance radius_square,
	frSquaredDistance radius_square,

Add support to LEF58_MAXSPACING in ODB and DRT #5287

Add support to LEF58_MAXSPACING in ODB and DRT #5287

Conversation

openroad-robot commented Jun 25, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

osamahammad21 commented Jul 29, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

maliberty commented Jul 29, 2024

maliberty left a comment

Choose a reason for hiding this comment

maliberty Jul 29, 2024

Choose a reason for hiding this comment

osamahammad21 commented Aug 5, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 6, 2024

Choose a reason for hiding this comment

github-actions bot Aug 6, 2024

Choose a reason for hiding this comment

github-actions bot Aug 6, 2024

Choose a reason for hiding this comment