refactor deltadebug #2057
Closed
refactor deltadebug #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: habibayassin <[email protected]>
oharboe
suggested changes
Jun 11, 2024
@oharboe what do you suggest? should it have the paths set in the script itself as a default? |
|
@habibayassin @maliberty There are now paths that I have never heard about that I have to pass in to deltaDebug.py. I just don't know what to make of it, so to my mind, the user interface to deltaDebug.py got worse... |
|
@habibayassin @vvbandeira @maliberty Are the deltaDebug.py tests hooked up to CI The-OpenROAD-Project/OpenROAD#5377 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged together with this PR in OR