-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main #3
Open
The-Ducktor
wants to merge
12
commits into
main
Choose a base branch
from
main-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
main #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Clear progress bar message before updating to avoid overlap feat: Conditionally add metadata based on presence of opf_file feat: Add function to check if FFmpeg is installed
feat: Update dependency version in Cargo.lock feat: Add genre to metadata extraction refactor: Remove unnecessary spacing in main.rs feat: Add interactive input prompt for file paths
…e file, improve user input handling in interactive mode
… main.rs Updated the user input function to improve code readability and created a helper function for validating file paths in the interactive input logic.
Enhance the `read_chapter` function to read chapters with a customized TTS voice name and ensure the chapter title is properly formatted by removing any leading '#' characters. Update the version number in `Cargo.toml` from 0.3.4 to 0.3.7 to reflect these changes. This improves the chapter output format and increases robustness in processing text data.
Add functionality to select a voice for text-to-speech during book generation. Update `make_book` function to accept a voice parameter and modify the `interactive_input` and `cli` functions to handle voice input. Update dependencies in `Cargo.lock` and `Cargo.toml` for compatibility. This enhances user experience by allowing customization of the voice used in audio generation.
Refactor the chapter title and content extraction logic in the `make` function. Replace the previous implementation with a more concise approach that utilizes iterators and filters to collect titles and contents. This change enhances code readability and maintainability while ensuring that only relevant chapters are processed based on filter criteria. Additionally, remove unnecessary variables and streamline the writing process to the output file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.