Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary files #3601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Secrus
Copy link

@Secrus Secrus commented Jan 5, 2025

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

This PR removes some files that are no longer necessary.

  • setup.py - GH has supported the pyproject.toml as a base for package discovery for some time now.
  • make.bat - a random duplicate of docs/make.bat, probably leftover from a docs setup
  • .coveragerc - moved the config to pyproject.toml since other tools are already configured there. pytest-cov requires the toml extra from coverage, so it should work OOTB. Also changed exclude_lines to exclude_also, which amends the default exclusion list instead of replacing it. By default pragma: no cover is ignored with this setting, so that entry was removed. The old config was deleted.

Don't know if the change should be added to the changelog, please advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant