Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Result Panel Getting Sticky Too Easily #3136

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

sixsage
Copy link
Collaborator

@sixsage sixsage commented Dec 2, 2024

Purpose

Address #3042
There was an issue where visualization results were very easy to make panels "sticky", meaning the panels would be dragged even though the user is no longer holding down the mouse. This PR aims to fix this issue.

Changes

Add logic to modify the z-index of visualization results directly. If the panel is being dragged, the visualization result's z-index becomes -1, and if the panel is not dragged, the z-index changes back to 0 so that the user can interact with the visualization.

Demo

Before
chrome_svDxLZYYvl
After
R3oNSHxH8J

@sixsage sixsage requested a review from aglinxinyuan December 15, 2024 11:19
@sixsage sixsage marked this pull request as ready for review December 15, 2024 11:19
Copy link
Collaborator

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sixsage sixsage merged commit fc3170a into master Dec 17, 2024
8 checks passed
@sixsage sixsage deleted the fix-sticky-issue branch December 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants