Fix Cell Export Bug (#3154)

This PR resolves a bug that prevented cell export functionality in the latest master branch. While cell export was previously supported, recent changes in prior PRs appear to have introduced an issue that disabled it. This update restores the export functionality, ensuring users can once again export cells as intended. https://github.com/user-attachments/assets/86876871-3b34-47a9-8b6f-c61bfe5b9573 Co-authored-by: Kunwoo Park <[email protected]>
Texera · Dec 14, 2024 · 9298d81 · 9298d81
1 parent 6cd3b51
commit 9298d81
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/core/gui/src/app/workspace/component/result-exportation/result-exportation.component.html b/core/gui/src/app/workspace/component/result-exportation/result-exportation.component.html
@@ -1,7 +1,7 @@
 <div class="centered-container">
   <div class="input-wrapper">
     <form nz-form>
-      <nz-row>
+      <nz-row *ngIf="exportType !== 'data'">
         <nz-col [nzSpan]="24">
           <nz-form-item>
             <nz-form-label nzFor="exportTypeInput">Export Type</nz-form-label>
@@ -28,6 +28,22 @@
           </nz-form-item>
         </nz-col>
       </nz-row>
+      <nz-row *ngIf="exportType === 'data'">
+        <nz-col [nzSpan]="24">
+          <nz-form-item>
+            <nz-form-label nzFor="filenameInput">Filename</nz-form-label>
+            <nz-form-control>
+              <input
+                id="filenameInput"
+                [(ngModel)]="inputFileName"
+                name="filename"
+                type="text"
+                nz-input
+                placeholder="Enter filename for binary data" />
+            </nz-form-control>
+          </nz-form-item>
+        </nz-col>
+      </nz-row>
       <nz-row>
         <nz-col [nzSpan]="24">
           <nz-form-item>
@@ -46,22 +62,6 @@
           </nz-form-item>
         </nz-col>
       </nz-row>
-      <nz-row *ngIf="exportType === 'data'">
-        <nz-col [nzSpan]="24">
-          <nz-form-item>
-            <nz-form-label nzFor="filenameInput">Filename</nz-form-label>
-            <nz-form-control>
-              <input
-                id="filenameInput"
-                [(ngModel)]="inputFileName"
-                name="filename"
-                type="text"
-                nz-input
-                placeholder="Enter filename for binary data" />
-            </nz-form-control>
-          </nz-form-item>
-        </nz-col>
-      </nz-row>
     </form>
   </div>
   <input

diff --git a/core/gui/src/app/workspace/component/result-exportation/result-exportation.component.ts b/core/gui/src/app/workspace/component/result-exportation/result-exportation.component.ts
@@ -24,7 +24,7 @@ export class ResultExportationComponent implements OnInit {
   rowIndex: number = inject(NZ_MODAL_DATA).rowIndex ?? -1;
   columnIndex: number = inject(NZ_MODAL_DATA).columnIndex ?? -1;
   destination: string = "";
-  exportType: string = "";
+  exportType: string = inject(NZ_MODAL_DATA).exportType ?? "";
   isTableOutput: boolean = false;
   isVisualizationOutput: boolean = false;
   containsBinaryData: boolean = false;