remove unused

Texera · Dec 29, 2024 · 1a7b159 · 1a7b159
1 parent 690a077
commit 1a7b159
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 37 deletions.
diff --git a/core/amber/src/main/scala/edu/uci/ics/texera/workflow/LogicalPlan.scala b/core/amber/src/main/scala/edu/uci/ics/texera/workflow/LogicalPlan.scala
@@ -3,9 +3,7 @@ package edu.uci.ics.texera.workflow
 import com.typesafe.scalalogging.LazyLogging
 import edu.uci.ics.amber.core.storage.FileResolver
 import edu.uci.ics.amber.core.tuple.Schema
-import edu.uci.ics.amber.core.workflow.WorkflowContext
 import edu.uci.ics.amber.operator.LogicalOp
-import edu.uci.ics.amber.operator.source.SourceOperatorDescriptor
 import edu.uci.ics.amber.operator.source.scan.ScanSourceOpDesc
 import edu.uci.ics.amber.virtualidentity.OperatorIdentity
 import edu.uci.ics.amber.workflow.PortIdentity
@@ -14,7 +12,6 @@ import org.jgrapht.graph.DirectedAcyclicGraph
 import org.jgrapht.util.SupplierUtil
 
 import java.util
-import scala.collection.mutable
 import scala.collection.mutable.ArrayBuffer
 import scala.jdk.CollectionConverters.SetHasAsScala
 import scala.util.{Failure, Success, Try}
@@ -64,7 +61,6 @@ case class LogicalPlan(
 
   def getTopologicalOpIds: util.Iterator[OperatorIdentity] = jgraphtDag.iterator()
 
-  def getOperator(opId: String): LogicalOp = operatorMap(OperatorIdentity(opId))
 
   def getOperator(opId: OperatorIdentity): LogicalOp = operatorMap(opId)
 
@@ -76,9 +72,6 @@ case class LogicalPlan(
       .filter(op => jgraphtDag.outDegreeOf(op) == 0)
       .toList
 
-  def getAncestorOpIds(opId: OperatorIdentity): Set[OperatorIdentity] = {
-    jgraphtDag.getAncestors(opId).asScala.toSet
-  }
 
   def getUpstreamOps(opId: OperatorIdentity): List[LogicalOp] = {
     jgraphtDag

diff --git a/core/amber/src/main/scala/edu/uci/ics/texera/workflow/LogicalPort.scala b/core/amber/src/main/scala/edu/uci/ics/texera/workflow/LogicalPort.scala
diff --git a/core/amber/src/main/scala/edu/uci/ics/texera/workflow/SinkInjectionTransformer.scala b/core/amber/src/main/scala/edu/uci/ics/texera/workflow/SinkInjectionTransformer.scala
diff --git a/...rkflow-compiling-service/src/main/scala/edu/uci/ics/amber/compiler/WorkflowCompiler.scala b/...rkflow-compiling-service/src/main/scala/edu/uci/ics/amber/compiler/WorkflowCompiler.scala
@@ -165,7 +165,7 @@ class WorkflowCompiler(
     // 1. convert the pojo to logical plan
     val logicalPlan: LogicalPlan = LogicalPlan(logicalPlanPojo)
 
-    // - resolve the file name in each scan source operator
+    // 2. resolve the file name in each scan source operator
     logicalPlan.resolveScanSourceOpFileName(Some(errorList))
 
     // 3. expand the logical plan to the physical plan

diff --git a/...workflow-operator/src/main/scala/edu/uci/ics/amber/operator/hashJoin/HashJoinOpDesc.scala b/...workflow-operator/src/main/scala/edu/uci/ics/amber/operator/hashJoin/HashJoinOpDesc.scala
@@ -121,7 +121,7 @@ class HashJoinOpDesc[K] extends LogicalOp {
           )
         )
 
-    new PhysicalPlan(
+    PhysicalPlan(
       operators = Set(buildPhysicalOp, probePhysicalOp),
       links = Set(
         PhysicalLink(

diff --git a/...perator/src/main/scala/edu/uci/ics/amber/operator/sentiment/SentimentAnalysisOpDesc.scala b/...perator/src/main/scala/edu/uci/ics/amber/operator/sentiment/SentimentAnalysisOpDesc.scala
@@ -57,8 +57,8 @@ class SentimentAnalysisOpDesc extends MapOpDesc {
       )
   }
 
-  override def operatorInfo =
-    new OperatorInfo(
+  override def operatorInfo: OperatorInfo =
+    OperatorInfo(
       "Sentiment Analysis",
       "analysis the sentiment of a text using machine learning",
       OperatorGroupConstants.MACHINE_LEARNING_GROUP,