Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use vars, use our #1010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't use vars, use our #1010

wants to merge 1 commit into from

Conversation

haarg
Copy link
Member

@haarg haarg commented Oct 17, 2024

No description provided.

@exodist
Copy link
Member

exodist commented Oct 17, 2024

I do not object to this, but I also am not sure what we gain? Can you explain the motivation for this change?

@toddr
Copy link
Contributor

toddr commented Oct 17, 2024

My comment would be that we've been telling people the right way to do it for years but we don't eat our own dog food.

This sort of thing in code that ships with Perl can confuse a less knowledgeable person. When they notice that the code that ships with Perl continues to use the old style, they think: "Maybe I should use it..."

@haarg
Copy link
Member Author

haarg commented Oct 17, 2024

It's also one less module to load, as minuscule of a benefit as that may be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants