Add gamepad rumble feature #954
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functionally this seems fine, though we could maybe make use of HD rumble to do more of a "tap" rather than a traditional rumble spin for some of the more subtle effects. This isn't easily exposed in SDL right now but we support enough devices now that it's probably worth considering for SDL3... Other than that, will leave the rest to Terry for design feedback. |
|
Filed libsdl-org/SDL#7509 |
Fussmatte
force-pushed
the
rumble
branch
2 times, most recently
from
23e5c55 to
6bad535
Compare
This commit adds a "rumble" option to the gamepad menu. Enabling it will add controller vibration to various parts of the game. Currently these events trigger a vibration, at varying degrees of intensity: - Deaths - Screen shakes - Touching checkpoints or teleporters - Touching gravity lines or gravity tokens - Collecting a trinket Further testing is likely needed. So far I have tested the feature using an 8bitdo SN30 Pro+ controller, in both Xinput and Switch modes. The rumble has different quality in either mode, and mileage may vary between other controllers, which I haven't fully tested.
A few print lines were left in by accident, causing the Game Pad and Rumble menu option titles to render over each other if the latter was high- lighted. This has been corrected.
The controllerRumble function has been cleaned up and now iterates over the map of connected controllers instead of opening handles each time rumble is used. The screenshake rumble functions have been moved into the title and game logic loops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR adds a rumble/vibration feature for players who use gamepads. It's implemented as a toggleable option (currently off by default) in the game pad options submenu.
Currently these events in the game will cause haptic feedback to occur (sorted here roughly from high to low intensity):
What still needs to be done:
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes