-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unfinished] Some patches #1213
Conversation
… detail into what went wrong
… middle of a line does not work. I didnt add it because I wanted to keep some of the retro simple feel.
Your changes should probably be in separate PRs.
I wrote #955 which has various text input improvements, including moving the cursor left/right
That's uh, quite an ambitious addition, maybe some discussion would be best first.
In my opinion, upscaler shaders have never looked good, and OmniScale doesn't seem like an exception... personal opinions aside, I don't think shaders make sense in the base repository, especially since we don't use shaders anywhere else yet. |
Hi! So to add a few more things: As Nyako said, there are multiple different changes in this PR, and it's better to make one PR per (related) change. Additionally, you may want to squash/fixup the commits a bit - the 1st commit adds a constant that's only defined in the 2nd one, which has a syntax error which is resolved in the 4th one, etc. Ideally, every individual commit can be compiled, and has a message describing the change (instead of "Some polish"). Don't make the first line of the commit message longer than 72 characters though. Or any further lines technically, but especially the first 😛
777 is often seen as a "dangerous" permissions value because it gives permission to everyone to do everything, but that's not really the case. That low-level user also needs access to every directory along the way, including your home directory. If your entire home directory is already open for every user to access, restricting access to your VVVVVV directory is the least of your worries. |
@Daaaav |
These can be reviewed separately once they've been cleaned up and finished - nothing in here is horrible but it's nicer to get emails for PRs that are finished (or at least a complete draft). |
Changes:
So far:
...and more that I am planning to add in the future:
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORS
file and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement